Skip to content

Update compiler_builtins to 0.1.79 #100380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2022
Merged

Update compiler_builtins to 0.1.79 #100380

merged 1 commit into from
Aug 13, 2022

Conversation

nicholasbishop
Copy link
Contributor

This pulls in a memcmp fix and some UEFI float-to-int fixes:
rust-lang/compiler-builtins@0.1.78...0.1.79

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 12, 2022

📌 Commit d1926eb has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2022
@bors
Copy link
Collaborator

bors commented Aug 13, 2022

⌛ Testing commit d1926eb with merge 75b7e52...

@bors
Copy link
Collaborator

bors commented Aug 13, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 75b7e52 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 13, 2022
@bors bors merged commit 75b7e52 into rust-lang:master Aug 13, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 13, 2022
@bors bors mentioned this pull request Aug 13, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (75b7e52): comparison url.

Instruction count

  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.0% -1.0% 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.0% -1.0% 1

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: ❌ relevant regressions found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.8% 4.0% 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results
  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: ❌ relevant regressions found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.2% 5.8% 2
Improvements ✅
(primary)		 -4.1% -4.1% 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -4.1% -4.1% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@nicholasbishop nicholasbishop mentioned this pull request Aug 14, 2022
Closed
@nicholasbishop nicholasbishop deleted the bishop-update-cb2 branch September 10, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nicholasbishop @rust-highfive @Mark-Simulacrum @bors @rust-timer @rustbot